Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add harvesting feature to handle missing controlled values #10323

Merged
merged 15 commits into from
Mar 18, 2024
Merged

Add harvesting feature to handle missing controlled values #10323

merged 15 commits into from
Mar 18, 2024

Conversation

stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Feb 15, 2024 •
edited
Loading

What this PR does / why we need it: Allows datasets to be harvested with Controlled Vocabulary Values that existed in the originating Dataverse Project but are not in the harvesting Dataverse Project.

Which issue(s) this PR closes: #9992

Closes #9992
Special notes for your reviewer:
Suggestions on how to test this: See HarvestingClientsIT.java for examples.

Does this PR introduce a user interface change? No

Is there a release notes update needed for this change?: in 9992-harvest-metadata-values-not-in-cvv-list.md

Additional documentation:

@stevenwinship stevenwinship self-assigned this Feb 15, 2024
@stevenwinship stevenwinship added Feature: Harvesting pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues Type: Feature a feature request User Role: Depositor Creates datasets, uploads data, etc. Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Feb 15, 2024
@coveralls
Copy link

coveralls commented Feb 15, 2024 •
edited
Loading

Coverage Status

coverage: 20.57% (+0.3%) from 20.262%
when pulling 5bb189b on 9992-harvest-metadata-missing-controlled-values
into f456e51 on develop.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@landreev
Copy link
Contributor

I'm leaning towards just approving this, not seeing anything to nitpick on.
@qqmyers thanks for the detailed input on the parsing/indexing earlier. Reading the current code there, it appears to be doing what we want, but please take a quick look/give it a thumbs up, just in case.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
landreev
landreev approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@stevenwinship stevenwinship mentioned this pull request Mar 6, 2024
Closed
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@cmbz cmbz mentioned this pull request Mar 12, 2024
Open
34 tasks
@sekmiller sekmiller self-assigned this Mar 14, 2024
@sekmiller
Copy link
Contributor

Do we care that there's not a UI change for this? That is when I set up a new client via the UI we aren't allowed to set the new param, nor do we see its value in the in the list of completed clients. Works fine when setting up client via api or if you modify the param directly in the db.

@sekmiller
Copy link
Contributor

Maybe we should say something about the new setting here: https://guides.dataverse.org/en/6.1/admin/harvestclients.html

@scolapasta scolapasta added this to the 6.2 milestone Mar 18, 2024
@github-actions GitHub Actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9992-harvest-metadata-missing-controlled-values

ghcr.io/gdcc/configbaker:9992-harvest-metadata-missing-controlled-values

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller sekmiller merged commit 4f46d15 into develop Mar 18, 2024
12 checks passed
@sekmiller sekmiller deleted the 9992-harvest-metadata-missing-controlled-values branch March 18, 2024 17:17
@pdurbin pdurbin mentioned this pull request Mar 28, 2024
Merged
luddaniel pushed a commit to Recherche-Data-Gouv/dataverse that referenced this pull request Aug 19, 2024
@stevenwinship @luddaniel
cherry-picking: Add harvesting feature to handle missing controlled v…
039c11c 
…alues IQSS#10323
luddaniel pushed a commit to Recherche-Data-Gouv/dataverse that referenced this pull request Aug 20, 2024
@stevenwinship @luddaniel
cherry-picking: Add harvesting feature to handle missing controlled v…
df0e38e 
…alues IQSS#10323
luddaniel pushed a commit to Recherche-Data-Gouv/dataverse that referenced this pull request Aug 21, 2024
@stevenwinship @luddaniel
cherry-picking: Add harvesting feature to handle missing controlled v…
bc46ae7 
…alues IQSS#10323
luddaniel added a commit to Recherche-Data-Gouv/dataverse that referenced this pull request Aug 22, 2024
@luddaniel
Merge pull request #7 from Recherche-Data-Gouv/picking_10323
3793db5 
cherry-picking: Add harvesting feature to handle missing controlled values IQSS#10323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqmyers qqmyers qqmyers left review comments

@github-actions GitHub Actions github-actions left review comments

@landreev landreev landreev approved these changes

Assignees

@sekmiller sekmiller

Labels
Feature: Harvesting pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) Type: Feature a feature request User Role: Depositor Creates datasets, uploads data, etc.
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

Feature Request/Idea: Harvest metadata values that aren't from a list of controlled values
6 participants
@stevenwinship @coveralls @landreev @sekmiller @qqmyers @scolapasta